lib: standardize use of lib and self#2332
Closed
MattSturgeon wants to merge 3 commits intonix-community:mainfrom
Closed
lib: standardize use of lib and self#2332MattSturgeon wants to merge 3 commits intonix-community:mainfrom
lib and self#2332MattSturgeon wants to merge 3 commits intonix-community:mainfrom
Conversation
Member
Author
|
CI failures have highlighted some cases where we use our custom types within our nixvim scoped lib. I wonder if types should once again be built within Another thing I'm wondering is perhaps
|
- Drop `helpers` in internal useage - Access nixvim's lib via `self` - Access the (un-extended) lib via `lib` - Build nixvim's types internally, before later merging into `lib.types` While I like the idea of having `lib.nixvim` access internally within our lib, keeping our lib (`self`) separate from the extended lib will be better in the long-term.
MattSturgeon
force-pushed
the
lib_self_cleanup
branch
from
f674162 to
932959d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done:
helpersin internal useageselflibWhile I like the idea of having
lib.nixvimaccess internally within our lib, keeping our lib (self) separate from the extended lib will be better in the long-term.This is intended to simplify accessing a lib overlay without needing to first evaluate parts of our custom lib (#2328).
lib/types.nixis a bit of a special case,lib.nixvimscoped) custom lib. Instead it is part of the lib extension overlay. Therefore we can use either strategy of passing it{ lib = final; }or{ lib = prev; inherit self; }. Feedback is welcome on which approach is preferred.EDIT: the above paragraph isn't true anymore. To avoid awkward bootstrapping we now (once again) build our types internally, as
lib.nixvim.types. This is still merged intolib.typesin the overlay though.